This repository was archived by the owner on Mar 12, 2026. It is now read-only.
Open
Conversation
|
I like this, and think it's a good idea. 👍🏻 |
Contributor
|
This makes sense to me too. 👍 |
segiddins
approved these changes
Oct 15, 2023
Contributor
segiddins
left a comment
segiddins
left a comment
There was a problem hiding this comment.
Definitely 👍🏻 on adding this, but I do want to see some consideration given for the best way to store the additional links, without being too inflexible for future evolution
| # Unresolved questions | ||
|
|
||
| - What mechanisms can we deploy to guarantee the appropriateness of external links? GitHub allows any link with no verification. | ||
| - How might these links factor into prospective verification processes in the future? |
Contributor
There was a problem hiding this comment.
This will tie in super nicely to rubygems/rubygems.org#4062, since it allows for verifying different types of entities. We could allow verifying user links in addition to rubygem links very easily
| For implementation: | ||
|
|
||
| 1. Add a new input field designated for the homepage URL. | ||
| 2. Integrate four input fields specifically for social network links. |
Contributor
There was a problem hiding this comment.
would we store 4 links directly on the User model? or add a CustomLink table, and allow a user to have_many :custom_links and then verify that they only have 4?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered proposal
I was iterating over user profile few times recently and it seems empty to me. Often I would like to get more info about gem author.
By making social links more generic, we can fix rubygems/rubygems.org#3321 and also make it simpler to maintain changes like Twitter to X renaming.